Skip to content

better faulty mod #1392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

better faulty mod #1392

wants to merge 3 commits into from

Conversation

cdc-sys
Copy link

@cdc-sys cdc-sys commented Jun 18, 2025

No description provided.

@dankmeme01 dankmeme01 requested a review from Copilot June 18, 2025 09:48
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR aims to refine the crash logging for faulty modules across different platforms by removing detailed mod logging.

  • Removed the lambda function that generated detailed mod information in Windows crash logs.
  • Removed mod log lines from Mac and iOS crash logs to streamline error reporting.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
loader/src/platform/windows/crashlog.cpp Removed detailed mod logging via a lambda function.
loader/src/platform/mac/crashlog.mm Removed a log entry that printed the mod ID.
loader/src/platform/ios/crashlog.mm Removed a log entry that printed the mod ID.
Comments suppressed due to low confidence (3)

loader/src/platform/windows/crashlog.cpp:451

  • The removal of detailed mod information in the Windows crash log could reduce context during debugging. If detailed mod data is valuable for troubleshooting, consider adding a concise log entry with the essential mod identifiers.
        stream

loader/src/platform/mac/crashlog.mm:169

  • Removing the mod ID log in the Mac crash log may limit debugging context. Reintroduce a succinct mod log entry if the mod identifier is needed for effective troubleshooting.
    stream << "Faulty Lib: " << getImageName(imageFromAddress(address)) << "\n";

loader/src/platform/ios/crashlog.mm:194

  • The removal of the mod logging in the iOS crash log may affect the available context for debugging. Consider whether a simplified mod identifier should still be logged to aid in diagnostics.
    stream << "Faulty Lib: " << imageName << "\n";

@altalk23 altalk23 closed this Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants