Skip to content

Create Indonesian language translation #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 23, 2020

Conversation

andyprasetya
Copy link
Contributor

No description provided.

@codeofsumit
Copy link
Contributor

Hi and thanks for the pull request. To make the language work, you also have to import the file here: https://github.com/codeofsumit/leaflet.pm/blob/develop/src/assets/translations/index.js

Copy link
Contributor

@codeofsumit codeofsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codeofsumit
Copy link
Contributor

Oh and please add it do the documentation as well

@andyprasetya
Copy link
Contributor Author

Sure, I'll do it.

Copy link
Contributor

@codeofsumit codeofsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is still missing the import of the language into index.js and the addition of the language in into the README.md

@codeofsumit codeofsumit self-requested a review February 23, 2020 13:29
Copy link
Contributor

@codeofsumit codeofsumit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the PR myself. Thanks for your contribution @andyprasetya 👍

@codeofsumit codeofsumit merged commit ae77be5 into geoman-io:develop Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants