Marker drag check #594
Merged
Marker drag check #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typo globaldrawmodetoggled --> globaldragmodetoggled
Create Base
Updated Swedish translations (geoman-io#571) (patch)
codeofsumit
suggested changes
May 20, 2020
|
@codeofsumit Both things added |
codeofsumit
reviewed
May 29, 2020
|
Yes it is difficult to understand. With this test it only checks if a error is thrown when goes into edit mode. |
|
Can a cypress test on github restarted? It stopped before tested ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if marker has dragging property before enable / disable dragging
Fix #567
When a marker is inactive (interactive: false) nothing can be done with it, but other layers still snapping to it. Maybe snapping should be also removed.