Skip to content

Changed checkout commit #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

AndrewChubatiuk
Copy link
Contributor

What type of PR is this?

changed checkout commit in github actions

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds sensible to me. 😄

@justinclift
Copy link
Member

Hmmm, this should be passing the frontend CI tests shouldn't it?

@AndrewChubatiuk
Copy link
Contributor Author

AndrewChubatiuk commented Feb 6, 2024

nope, it relies on config in master also CI is broken and fix is here

@justinclift justinclift merged commit 320fddf into getredash:master Feb 6, 2024
@justinclift
Copy link
Member

Ahhh, no worries. Merged.

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
* Snapshot: 24.02.0-dev

* changed checkout commit

---------

Co-authored-by: github-actions <[email protected]>
Co-authored-by: Andrew Chubatiuk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants