Skip to content

Add data type to redshift query runner #7109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Aug 5, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Redshift system table SVV_COLUMNS supports data_type. We should make good use of it since the existing postgresql runner (pg.py) has been updated to accommodate data type since 2020 (see #5052).

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😄

@justinclift justinclift merged commit a4f92a8 into getredash:master Aug 5, 2024
11 checks passed
@zachliu zachliu deleted the add-data_type-to-redshift-query-runner branch August 6, 2024 00:23
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants