Skip to content

Add data type to athena query runner #7112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

zachliu
Copy link
Contributor

@zachliu zachliu commented Aug 7, 2024

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Both Athena's information_schema & boto3 Glue's get_tables method support data_type. We should make good use of it! 💪

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

athena

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@justinclift
Copy link
Member

Seems pretty straight forward, lets get it merged. 😄

@justinclift justinclift enabled auto-merge (squash) August 7, 2024 03:08
@justinclift justinclift merged commit 285c2b6 into getredash:master Aug 7, 2024
11 checks passed
@zachliu zachliu deleted the add-data_type-to-athena-query-runner branch August 7, 2024 13:44
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants