refactor: use java.net.URI
for parsing URLs in UrlUtils
#4210
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
This changes the internal logic used for parsing URLs in
UrlUtils
from regex based to usingjava.net.URI
.This will allow the SDK to handle the cases described in #2690 and getsentry/team-sdks#39.
java.net.URI
is known to still not be fully compliant with RFCs 3986 and 3987 (https://cr.openjdk.org/%7Edfuchs/writeups/updating-uri/) but this is still an improvement with respect to the cases described in the issues linked above, and could also ensure correct handling for other corner cases that we are not aware of.We still use
java.net.URL
but just for validating that an URI is a valid URL.This could affect grouping for existing issues that use (parts of) an URL as the message when the URL falls in the affected corner cases.
💡 Motivation and Context
Closes #2690
💚 How did you test it?
Added some tests and changed existing ones
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps