Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cold app start detection and activity timespan generation back t… #4214

Open
wants to merge 3 commits into
base: 7.x.x
Choose a base branch
from

Conversation

markushi
Copy link
Member

📜 Description

Still a draft, but moves the duty of collecting Activity Spans and setting the app start type back to the ContentProvider. This allows us to collect performance data, even if the SDK itself is initialized async. E.g. for React Native where the first Activity.onCreate() happens before SentryAndroid.init().

💡 Motivation and Context

Fixes getsentry/sentry-react-native#4598

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

…o SentryPerformanceProvider

Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Move cold app start detection and activity timespan generation back t… ([#4214](https://github.com/getsentry/sentry-java/pull/4214))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 2e0425e

Copy link
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 399.61 ms 442.00 ms 42.39 ms
Size 1.70 MiB 2.36 MiB 672.36 KiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant