Fix Ensure app start type is set, even when ActivityLifecycleIntegration is not running #4216
Conversation
markushi
requested review from
adinauer,
romtsn and
stefanosiano
as code owners
Performance metrics 🚀
|
| @Override | ||
| public void onActivityCreated( | ||
| @NotNull Activity activity, @Nullable Bundle savedInstanceState) { | ||
| if (appStartMetrics.getAppStartType() == AppStartMetrics.AppStartType.UNKNOWN) { |
There was a problem hiding this comment.
I would duplicate the logic of the ActivityLifecycleIntegration
That should save us from a lot of headaches.
Or we can move the logic inside the AppStartMetrics, passing the required uptimeMillis and the Activity Bundle, since it has everything needed to check whether it's a cold or warm start. That way, the code would not even be duplicated, and it would work as expected.
There was a problem hiding this comment.
and I'd add a comment on why we do this (react native not passing an Application and initializing the SDK too late)
There was a problem hiding this comment.
From my testing, the condition appStartSpan.hasStopped() from ActivityLifecycleIntegration will never evaluate to true within this content provider, causing no warm starts to be detected. This content provider runs before any SDK init, so there's no other component able to stop the span.
There was a problem hiding this comment.
In the long I would love to see ActivityLifecycleIntegration being split up into several components:
- One for app-starts
- One for profiling
- One for TTID/TTFD
- One for activity lifecycle after app-start
Fix Ensure app start type is set, even when ActivityLifecycleIntegration is not running or init is deferred.
Fixes getsentry/sentry-react-native#4598