[hal-0.3] Upgrade to raw-window-handle v0.3.0 #3037
Conversation
There was a problem hiding this comment.
Thank you for the PR!
Unfortunately, we can't simply update this dependency to another semver-incompatible version, since it's a public dependency, and the public types we use (I assume) are not semver-hacked.
We'd have to keep the 0.1 dependency for hal-0.3. We can add add other entry points that work with 0.3 dependency.
Good thing is that hal-0.4 is just around the corner, so if we have this in master, we'll get it with the release.
|
@kvark how does the versioning work for this repo? I just added it to |
|
@antonok-edm the "hal-0.3" branch contains fixes to "hal-0.3" crate and dependencies (e.g. backends). The"master" branch contains latest and greatest stuff. A change to bring raw-window-handle to "master" is #2967, and it has unfortunately stalled. Big thanks if you can get it rolling! |
3038: Replace `winit` with `raw-window-handle` in backend crates r=kvark a=antonok-edm Fixes #2956, closes #2967 PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: `vulkan` - [x] `rustfmt` run on changed code I've rebased @jchapman127's work off of the latest `master`. Unfortunately, `winit` has not yet updated past `raw-window-handle` v0.1.2, so #3037 will have to wait. Anything else that needs to be done? Co-authored-by: James Chapman <[email protected]>
|
Now it's time to upgrade master to |
|
Ah, there's no way to change which branch a PR merges into... I can create a new one |
|
There is. Use |
|
Oh... that's news to me 😅 |
3050: Upgrade to raw-window-handle v0.3 r=kvark a=antonok-edm Reopening #3037 against `master`, for merge whenever ready. Note that compiling examples currently doesn't work because `winit` still imports the old version of `raw-window-handle`; the two versions of the traits are incompatible. PR checklist: - [x] `make` succeeds (on *nix) - [x] `make reftests` succeeds - [x] tested examples with the following backends: `vulkan` - [x] `rustfmt` run on changed code Co-authored-by: Anton Lazarev <[email protected]>
PR checklist:
makesucceeds (on *nix)make reftestssucceedsvulkanrustfmtrun on changed codeIn the process, I've also added support for building a Vulkan surface using a raw XCB handle.