Add NeoBERT #14164
Open
Add NeoBERT #14164
+222
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggerganov
approved these changes
Jun 13, 2025
ggerganov
reviewed
Jun 13, 2025
Comment on lines
+531
to
+532
| if self.model_arch == gguf.MODEL_ARCH.NEO_BERT: | ||
| n_ff = int(2 * n_ff / 3) # NeoBERT uses 2/3 of the intermediate size as feed forward length |
There was a problem hiding this comment.
I don't think this is the right place to override this. Move it to the NeoBert class
There was a problem hiding this comment.
I think that's problematic as you can't use the base method then without getting duplicate keys, alternatively, just deactivate setting this value here, similar to the head_dim workaround for DeepSeekV3.
There was a problem hiding this comment.
I see. In any case we should try to avoid stacking up special cases here in some way. Maybe add a function that allows to override existing keys?
There was a problem hiding this comment.
We could add an override option to the GGUFWriter methods I suppose.
ggerganov
reviewed
Jun 13, 2025
Co-authored-by: Georgi Gerganov <[email protected]>
Co-authored-by: Georgi Gerganov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support NeoBERT