Do not crash when it has nothing to say. #796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slaren
reviewed
Apr 5, 2023
|
On Wed, Apr 05, 2023 at 04:05:45PM -0700, slaren wrote:
@slaren commented on this pull request.
> @@ -431,7 +431,7 @@ int main(int argc, char ** argv) {
}
// end of text token
- if (embd.back() == llama_token_eos()) {
+ if (embd.empty() || embd.back() == llama_token_eos()) {
Shouldn't this be `!embd.empty() &&` ..? What is the purpose of hitting this path when `embd` is empty?
--
Reply to this email directly or view it on GitHub:
#796 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
Indeed, thanks!
…--
() ascii ribbon campaign - against html mail
/\ http://arc.pasp.de/ - against proprietary attachments
|
Otherwise observing this in the interactive mode: /usr/lib/gcc/x86_64-pc-linux-gnu/12/include/g++-v12/bits/stl_vector.h:1230: reference std::vector<int>::back() [_Tp = int, _Alloc = std::allocator<int>]: Assertion '!this->empty()' failed.
slaren
approved these changes
Apr 5, 2023
I got it to happen somewhat reliably after asking alpaca w/ the bob prompt "How do you do?" and then "OK.", but it's generally often does this for me on subsequent inquiries. Also i have a hypothesis that most users use an older/non-hardened version of the gcc's standard libarary that doesn't assert stuff, so it silently compares some garbage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise observing this in the interactive mode:
/usr/lib/gcc/x86_64-pc-linux-gnu/12/include/g++-v12/bits/stl_vector.h:1230: reference std::vector::back() [_Tp = int, _Alloc = std::allocator]: Assertion '!this->empty()' failed.