-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Go binding: NewContext now returns a clean context #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Setting the no_context to |
@ggerganov in what case the lib user wants to create a new Golang context but keep the past transcription text? Why not just use the existing Go context? On the other hand, I believe it makes more sense that NewContext returns a truly new context, rather than a context remembers past transcription. |
Edit: ignore this, it's wrong |
@ggerganov I made the change following our convo here. I've verified that w/o this change, Go context returned by NewContext may mess up the transcription (likely because it carries over previous context) |
@polarmoon |
Co-authored-by: Ming <ming@localhost>
Co-authored-by: Ming <ming@localhost>
Co-authored-by: Ming <ming@localhost>
Co-authored-by: Ming <ming@localhost>
Co-authored-by: Ming <ming@localhost>
It makes more sense to return a clean context upon
NewContext
call