Update from master #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added subscriptions support to makeRemoteExectuableSchema
* Update schemaRecreation.ts `mergeSchemas` does not set `astNode` properties, when recreating types. But `CacheControlExtension.willResolveField` uses the `astNode` property in order to get the `cacheControl` directives.
* Allow IEnumResolver values to be number type
…rfaces (#546) * add failing test for multi interface issue * interface / interface always implements an abstract type * changelog * the linter always should be happy * Update CHANGELOG.md
Remove graphql-subscriptions from devDependencies
…es (#586) Fixing the args with zero value or false
* Also recreate astNode for fields In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries. * Add ast to input field node too
…609) * fix(subscriptions): The subscription resolvers were firing too often The underlying subscription in a remote schema was not terminated properly, causing memory leaks. In addition, multiple subscriptions caused duplicate payloads. Both is fixed by removing the PubSub dependency and directly transforming the Observer returned by the ApolloLink to an async iterable. This allows the async iterable to propagate to the underlying observable to cancel the suscription once the subscription is not needed anymore. * refactor(test): remove timeout from test * chore(changelog): add fix to changelog
* add tests demonstrating bug with var generation * add deduping of new variable definitions when delegating to schemas * update changelog.md
* Allow passing an array of resolver functions to makeExecutable schema - Closes #486 * Implement passing an array of resolvers sets to mergeSchemas * Introduce unit or array composite type * Fix @types dep * Fix resolvers to accept and move forward args with zero or false values (#586) Fixing the args with zero value or false * Also recreate astNode for fields (#580) * Also recreate astNode for fields In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries. * Add ast to input field node too * Address comments, remove lodash * Fix @types dep * Fix resolvers to accept and move forward args with zero or false values (#586) Fixing the args with zero value or false * Also recreate astNode for fields (#580) * Also recreate astNode for fields In a [previous commit](fd9f626) we added the `astNode` property in the `reacreateCompositeType` function. That resulted in cache control working with schema stitching but only for GraphQL Types. By recreating the `astNode` prop also in `fieldToFieldConfig` cache control also works for fields. This is required for caching fields and hence queries. * Add ast to input field node too * Address comments, remove lodash * Use mergeDeep instead of lodash.merge * Fix build * Changelog and separate utility * Update CHANGELOG
* Recreate enums and scalars in mergeSchema
…k-http (#621) * fix(schema-stitching): Pass through error when coming from apollo-link-http This is needed in order to handle custom properties on the GraphQLError object, like `code` or `requestId` * refactor(schema-stitching): Remove redundant type information * chore(changelog): Add PR to changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.