fix user effective permission display #1100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with different permissions
|
The weird thing to me is that team permissions override specified user permissions. I believe it should be the other way around. But yeah, at least the displayed permissions should reflect the ones applied when checking access. |
flaix
added a commit
that referenced
this pull request
Aug 7, 2022
This pulls in the rebased branch from PR #1100.
|
Rebased and merged. Closing this as done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was issue if users is in multiple groups, then in access permissions tab under effective was shown only alphabetically first groups permissions, not the greatest ones. Fixed issue by adding some checks if permissions should be replaced in list. Maybe there is better way to fix this issue. (I am not really developer, just SCM engineer)