C++: Support the __mfp8 floating point type
#19688
Merged
+13,869
−3,882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
added
the
depends on internal PR
jketema
force-pushed
the
mfp8
branch
2 times, most recently
from
cad12d4 to
883d23c
Compare
There was a problem hiding this comment.
Pull Request Overview
Adds full support for the new __mfp8 built-in floating-point type across tests, DB schema, query logic, and upgrade/downgrade scripts.
- Extend all relevant library-test expectations to include
__mfp8 - Map value 62 to
__mfp8insemmlecode.cpp.dbschemeandType.qll - Provide upgrade and downgrade scripts for the new type
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cpp/ql/test/library-tests/variables/variables/types.expected | Added __mfp8 to variable types table |
| cpp/ql/test/library-tests/unspecified_type/types/unspecified_type.expected | Added __mfp8 to unspecified types |
| cpp/ql/test/library-tests/type_sizes/type_sizes.expected | Added size expectation (1) for __mfp8 |
| cpp/ql/test/library-tests/templates/type_instantiations/types.expected | Added __mfp8 to template instantiations |
| cpp/ql/lib/upgrades/9a7c3c14c1076f64b871719117a558733d987b48/upgrade.properties | Describes full upgrade support for __mfp8 |
| cpp/ql/lib/semmlecode.cpp.dbscheme | Maps built-in kind 62 to @mfp8 |
| cpp/ql/lib/semmle/code/cpp/Type.qll | Extends floatingPointTypeMapping to include __mfp8 |
| cpp/downgrades/af887e83a815a9cefe774ffa80e2493a1365b9e2/upgrade.properties | Describes backward downgrade support for __mfp8 |
| cpp/downgrades/af887e83a815a9cefe774ffa80e2493a1365b9e2/builtintypes.ql | Adds downgrade mapping for kind 62 → kind 1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.