-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix typo from occured
to occurred
#17673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BaseMax
wants to merge
1
commit into
github:master
Choose a base branch
from
MaxFork:max-updates-typo-mistake-occured-to-occurred
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,7 @@ | |
I am the copyright owner. | ||
|
||
**Please provide a detailed description of the original copyrighted work that has allegedly been infringed. If possible, include a URL to where it is posted online.** | ||
The work in question is a C/C++ library RadioLib (available at https://github.com/jgromes/RadioLib). It is an embedded driver for various wireless communication modules. Amongst the supported wireless modules is the SX126x family of LoRa radio modules. It has recently occured to me that a different GitHub project (https://github.com/tinytronix/SX126x) is using substantial parts of RadioLib code without any mention of RadioLib or its original license. RadioLib is licensed under the MIT License, which clearly states that: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." I firmly believe that this use of RadioLib is in violation of its license. | ||
The work in question is a C/C++ library RadioLib (available at https://github.com/jgromes/RadioLib). It is an embedded driver for various wireless communication modules. Amongst the supported wireless modules is the SX126x family of LoRa radio modules. It has recently occurred to me that a different GitHub project (https://github.com/tinytronix/SX126x) is using substantial parts of RadioLib code without any mention of RadioLib or its original license. RadioLib is licensed under the MIT License, which clearly states that: "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software." I firmly believe that this use of RadioLib is in violation of its license. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Corrected the typo from 'occured' to 'occurred'. Copilot uses AI. Check for mistakes. Positive FeedbackNegative Feedback |
||
|
||
**What files should be taken down? Please provide URLs for each file, or if the entire repository, the repository’s URL:** | ||
https://github.com/tinytronix/SX126x/blob/master/SX126x.cpp | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Corrected the typo from 'occured' to 'occurred'.
Copilot uses AI. Check for mistakes.