Skip to content

Major update #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Major update #90

wants to merge 1 commit into from

Conversation

koddsson
Copy link
Contributor

Removing a ton of stuff I don't think we need any more as well as trying to simplify the whole repo, hoping to eventually get down to a list of rules and their documentation.

I'm down to reverting any of these changes if you think we should still keep it.

This is a first pass and I want to do more after this is merged.

@koddsson koddsson requested a review from a team March 12, 2020 16:08
package.json Outdated
Comment on lines 32 to 33
"engines": {
"node": ">=8.11.1"
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this isn't used for anything.

@koddsson
Copy link
Contributor Author

One thing we could do is create a new eslint-config-github repo and keep the current repo as is. That would mean that this repo can just be deprecated and archived.

@koddsson
Copy link
Contributor Author

One thing we could do is create a new eslint-config-github repo and keep the current repo as is. That would mean that this repo can just be deprecated and archived.

Apparently you need to name the package plugin in order for you to define your own rules. With that in mind I might just break this PR into smaller PRs and keep it in the same repo. I'll bump the major version once I got all those PRs out and maaayyybe rename the package to something like @github/eslint-plugin.

@koddsson koddsson force-pushed the major-update branch 2 times, most recently from aadae90 to 38983b2 Compare March 18, 2020 13:26
@koddsson koddsson force-pushed the major-update branch 2 times, most recently from d9c9fe7 to 41b71d0 Compare March 19, 2020 09:31
@koddsson koddsson force-pushed the major-update branch 2 times, most recently from ba1fd36 to 95cbc67 Compare March 19, 2020 14:59
@koddsson koddsson mentioned this pull request Mar 19, 2020
@koddsson
Copy link
Contributor Author

image

There's more stuff to do for 4.0.0. I'll open up a tracking issue for those outstanding issues.

@koddsson koddsson closed this Mar 23, 2020
@koddsson koddsson deleted the major-update branch March 23, 2020 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant