Add event button classname is not applied #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love the update, thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
@AndreaGriffiths11 Made the events grid so much prettier 🤩
However, there are a couple of things I noticed:
In the process of messing with this, I discovered a third thing. There are classes that are not applied because, while the
classNameprop was passed to the button link, the button link doesn't accept aclassNameprop and so it is never applied.After
With all fixes applied, the new section looks like this:
The button is white due to changes made in PR #260 by @AndreaGriffiths11. See the specific diff here:
https://github.com/github/maintainermonth/pull/260/files#diff-da275896c80ebad87819e008c15b36a54697e45dfe79e5d4f61f205365b66c6dR27
I could revert this if you think it would look better the other way.
Other button links look the same as before but with the correct icon color. Example:
Before:
After:
I'm sure you can think of plenty of changes to make, please give feedback! ❤️
I also have a question for the maintainers. What is the contributing process? Should contributors always create an issue before making a PR, or can they just make a PR (like I just did 😳)? Thanks!