Configurable handlers #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to configurable-handlers
|
Waiting for this pull request to be merged |
|
Hey all, I don't really have any projects to test this with any more - though that will be changing when I find the time. If you get a chance to check it and it works for you, let me know and I'll see about merging this. |
|
It's been a while and we've got people using similar setups already, so I feel comfortable merging this. Next tag will be a minor version bump (as with semver 0.x I'm pretty sure minor bumps can be breaking) rather than a patch version. |
|
This is working great for me so far in a proxy server I wrote. Thanks for developing this and merging @belak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the configurable-handlers branch, brings some of our handler code more in line with what the stdlib does, and disables port forwarding by default with an option to enable it (we really shouldn't have shipped it like this by default).
This does break backwards compatibility (handler changes specifically) but adds quite a bit of flexibility without sacrificing complexity for people who just want to use this package out of the box.
This directly replaces #89