Skip to content

fix/multistep-questionnaire #4339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 29, 2024
Merged

fix/multistep-questionnaire #4339

merged 3 commits into from
Nov 29, 2024

Conversation

msmannan00
Copy link
Member

fix(multistep-questionnaire): bind required file/audio upload check to model

Fixed a bug in the multistep questionnaire where the required check for file or audio uploads was not functioning correctly. Updated the binding of the "required" condition to use the actual model fields, ensuring proper validation.

Problem

The validation for required file/audio uploads in the multistep questionnaire was not functioning as intended because the condition was not bound to the actual model fields and caused required check to skip

Solution

The "required" condition was updated to bind directly to the model fields, ensuring that the validation logic works as expected. logic for required field was also fixed and updated

Fixed a bug in the multistep questionnaire where the required check for file or audio uploads was not functioning correctly. Updated the binding of the "required" condition to use the actual model fields, ensuring proper validation.
@msmannan00 msmannan00 requested a review from a team as a code owner November 29, 2024 11:46
Copy link

codacy-production bot commented Nov 29, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.58% (target: +0.50%) 84.21% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (499ca4a) 27324 21939 80.29%
Head commit (990c9ef) 46321 (+18997) 37460 (+15521) 80.87% (+0.58%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4339) 19 16 84.21%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@evilaliv3
Copy link
Member

Fantastic! I retested it and i've not found any defect.

Merging it!

@evilaliv3 evilaliv3 merged commit 5780714 into devel Nov 29, 2024
11 of 12 checks passed
@evilaliv3 evilaliv3 deleted the fix/file-upload-validations branch November 29, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants