Skip to content

Duplicating a note does not adjust encoded images paths #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tewe opened this issue Nov 4, 2021 · 3 comments
Closed

Duplicating a note does not adjust encoded images paths #1241

tewe opened this issue Nov 4, 2021 · 3 comments
Assignees

Comments

@tewe
Copy link

tewe commented Nov 4, 2021

Description

When duplicating a (non-TextBundle) note, any images are copied. But the new note will still point to the original files if the path is URL-encoded.

To Reproduce

  1. Make sure you container is not set to TextBundle
  2. Start a new note
  3. Drag an image with whitespace in the filename into the note (I used screenshots created by the screenshot feature built into macOS)
  4. File > Duplicate the note

Expected behavior

The Markdown image link in the note changes to a UUID.

FSNotes version

5.1.2

macOS/iOS version

macOS 10.14.6

Additional context

The Note move function does a search & replace based on the output of getAllImages, which removes any encoding.

@tewe
Copy link
Author

tewe commented Nov 4, 2021

#715

@glushchenko
Copy link
Owner

@tewe
Copy link
Author

tewe commented Apr 24, 2022

IMHO a bit of a hack, but works for me. Thanks!

@tewe tewe closed this as completed Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants