Skip to content

Move query-scoped data to a separate data type accessed by Rows.Finish() #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 6, 2022

Conversation

flimzy
Copy link
Member

@flimzy flimzy commented Jan 6, 2022

Closes #552

@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #554 (a057c6d) into master (b5116f3) will increase coverage by 0.06%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #554      +/-   ##
==========================================
+ Coverage   87.13%   87.19%   +0.06%     
==========================================
  Files          21       21              
  Lines        1158     1156       -2     
==========================================
- Hits         1009     1008       -1     
+ Misses        105      103       -2     
- Partials       44       45       +1     
Impacted Files Coverage Δ
row.go 13.88% <0.00%> (-0.82%) ⬇️
rows.go 84.67% <92.85%> (+1.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5116f3...a057c6d. Read the comment docs.

@flimzy flimzy merged commit 906953d into master Jan 6, 2022
@flimzy flimzy deleted the resultstatus branch January 6, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving some of the Rows methods to a new type
1 participant