Skip to content

Fix action name for ui_colorpicker_delete_preset in built-in InputMap #107471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jun 13, 2025

The old action name is a leftover from a now-reverted PR.

I noticed this while working on #39708 🙂

The old action name is a leftover from a now-reverted PR.
@Calinou Calinou requested a review from a team as a code owner June 13, 2025 00:25
@Calinou Calinou added this to the 4.5 milestone Jun 13, 2025
@roughbits01
Copy link
Contributor

roughbits01 commented Jun 13, 2025

@Calinou Noticed the same issue while working on a different PR. BTW I have some related changes if you can take a look #107487 (I removed ui_colorpicker_delete_preset renaming from my PR).

@akien-mga
Copy link
Member

That's a super niche input action and we should reconsider whether it's really warranted IMO. But for now it makes sense to fix its name.

@akien-mga akien-mga merged commit 60ba4ba into godotengine:master Jun 13, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou deleted the input-map-fix-colorpicker-action-name branch June 13, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants