theme: Remove the print only QR code header #3095
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had a head scratching moment wondering where the qr codes directly below public/ came from. I understand the motivation, but this produces a little too many files for this ... narrow feature.
|
Would you consider a compromise where we use the existing (cached) QR codes instead? |
My biggest gripe about this was the "thousands" of PNG files in the I'm closing this. We can keep the "print" header (it does add some value), but we should 1. Move the QR codes below /images (and maybe also one level down e.g. /images/qr/...)and possibly also make sure that we only generate one set ... |
|
Yeah, I should have re-used the images when I implemented this. I'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a head scratching moment wondering where the qr codes directly below public/ came from.
I understand the motivation, but this produces a little too many files for this ... narrow feature.