cmd/compile: remove redundant function pkgNameOf #64075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

aimuz wants to merge 1 commit into golang:master from aimuz:for-62037

Contributor

aimuz commented Nov 12, 2023 •

edited

Loading

Replace calls to pkgNameOf with calls to types2.Info.PkgNameOf.
Delete function pkgNameOf and file decl.go which are not needed anymore.


          cmd/compile: remove redundant function pkgNameOf

3c8928f

The decl.go file in cmd/compile/internal/noder has been removed as its
only contained function, pkgNameOf, is now redundant. This change updates
the references of this function to use the method PkgNameOf directly from
the *types2.Info struct.

For golang#62037

Contributor

gopherbot commented Nov 12, 2023

This PR (HEAD: 3c8928f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/541738.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

Contributor

gopherbot commented Nov 12, 2023

Message from qiulaidongfeng:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 12, 2023

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 12, 2023

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 12, 2023

Message from Keith Randall:

Patch Set 1: Auto-Submit+1 Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 12, 2023

Message from Keith Randall:

Patch Set 1: Code-Review+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 12, 2023

Message from Robert Griesemer:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

Contributor

gopherbot commented Nov 13, 2023

Message from Aimuz me:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/541738.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request


          cmd/compile: remove redundant function pkgNameOf

0c66ae5

Replace calls to pkgNameOf with calls to types2.Info.PkgNameOf.
Delete function pkgNameOf and file decl.go which are not needed anymore.

For #62037

Change-Id: Ib8a0411cc9eb9fdd42ee6e73c23deed2daaf73d5
GitHub-Last-Rev: 3c8928f
GitHub-Pull-Request: #64075
Reviewed-on: https://go-review.googlesource.com/c/go/+/541738
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Run-TryBot: Robert Griesemer <[email protected]>
Run-TryBot: qiulaidongfeng <[email protected]>
Auto-Submit: Robert Griesemer <[email protected]>
Reviewed-by: Keith Randall <[email protected]>
Reviewed-by: Robert Griesemer <[email protected]>

Contributor

gopherbot commented Nov 13, 2023

This PR is being closed because golang.org/cl/541738 has been merged.

gopherbot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet