Skip to content

Commit a9db481

Browse files
committed
[release] prepare v0.39.1 release
3eafcb4 CHANGELOG.md: update for v0.39.1 9e7f858 src/goDeveloperSurvey: update survey link and dates 75770e1 package.json: add gopls.start_debugging 5f5a875 build/Dockerfile: skip global typescript, vsce installation 0de0e11 build: remove unused, outdated cloudbuild config 3b2da9a package.json: prepare for the v0.40.0 dev cycle fb1dce6 package.json: align snippetsPreventQuickSuggestions with VS Code default Change-Id: I9e1f5d40b5128c4c829850139aef92d26c18907f
2 parents c328218 + 3eafcb4 commit a9db481

13 files changed

+43
-76
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## v0.39.1 - 17 Jul, 2023
2+
3+
This is a point release to update the link for the upcoming Go developer survey.
4+
A list of changes can be found in the full [commit history](https://github.com/golang/vscode-go/compare/v0.39.1...v0.39.0).
5+
16
## v0.39.0 - 12 Jun, 2023
27

38
We are in the process of removing legacy language features that were replaced by `gopls` since early 2021. The versions released after September 2023 will no longer offer features like code completion, navigation, documentation, formatting, and refactoring if the language server is disabled. In this release, we are showing deprecation notification messages if you are using the legacy language features. ([Issue 2799](https://github.com/golang/vscode-go/issues/2799))

build/Dockerfile

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ ENV DEBIAN_FRONTEND noninteractive
2626
ENV NODE_OPTIONS --dns-result-order=ipv4first
2727

2828
RUN apt-get -qq update && apt-get install -qq -y libnss3 libgtk-3-dev libxss1 libasound2 xvfb libsecret-1-0 jq > /dev/null
29-
RUN npm install -g typescript @vscode/vsce
3029

3130
USER node
3231
WORKDIR /workspace
33-
ENTRYPOINT ["build/all.bash"]
32+
ENTRYPOINT ["build/all.bash"]

build/README.md

Lines changed: 0 additions & 1 deletion
This file was deleted.

build/cloudbuild.container.yaml

Lines changed: 0 additions & 5 deletions
This file was deleted.

build/cloudbuild.yaml

Lines changed: 0 additions & 9 deletions
This file was deleted.

docs/commands.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -159,6 +159,10 @@ Toggles between file in current active editor and the corresponding test file.
159159

160160
Toggle the display of vulnerability analysis in dependencies.
161161

162+
### `Go: Start language server's maintainer interface`
163+
164+
Start the Go language server's maintainer interface (a web server).
165+
162166
### `Go: Add Tags To Struct Fields`
163167

164168
Add tags configured in go.addTags setting to selected struct using gomodifytags

docs/testing.md

Lines changed: 0 additions & 48 deletions
This file was deleted.

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "go",
33
"displayName": "Go",
4-
"version": "0.39.0",
4+
"version": "0.39.1",
55
"publisher": "golang",
66
"description": "Rich Go language support for Visual Studio Code",
77
"author": {
@@ -36,7 +36,7 @@
3636
],
3737
"scripts": {
3838
"clean": "rm -rf ./dist/* && rm *.vsix",
39-
"package": "vsce package",
39+
"package": "npx vsce package",
4040
"vscode:prepublish": "npm run compile",
4141
"bundle": "esbuild src/goMain.ts debugAdapter=src/debugAdapter/goDebug.ts --bundle --outdir=dist --external:vscode --format=cjs --platform=node",
4242
"bundle-dev": "npm run bundle -- --sourcemap",
@@ -216,8 +216,7 @@
216216
"editor.formatOnSave": true,
217217
"editor.codeActionsOnSave": {
218218
"source.organizeImports": true
219-
},
220-
"editor.suggest.snippetsPreventQuickSuggestions": false
219+
}
221220
}
222221
},
223222
"commands": [
@@ -397,6 +396,11 @@
397396
"title": "Go: Toggle Vulncheck",
398397
"description": "Toggle the display of vulnerability analysis in dependencies."
399398
},
399+
{
400+
"command": "go.languageserver.maintain",
401+
"title": "Go: Start language server's maintainer interface",
402+
"description": "Start the Go language server's maintainer interface (a web server)."
403+
},
400404
{
401405
"command": "go.add.tags",
402406
"title": "Go: Add Tags To Struct Fields",

src/commands/index.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ export { runBuilds } from './runBuilds';
2121
export { showCommands } from './showCommands';
2222
export { startDebugSession } from './startDebugSession';
2323
export { startLanguageServer } from './startLanguageServer';
24+
export { startGoplsMaintainerInterface } from './startLanguageServer';
2425
export { toggleGCDetails } from './toggleGCDetails';
2526

2627
type CommandCallback<T extends unknown[]> = (...args: T) => Promise<unknown> | unknown;

src/commands/startLanguageServer.ts

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -138,3 +138,19 @@ function shouldActivateLanguageFeatures() {
138138
}
139139
return true;
140140
}
141+
142+
export const startGoplsMaintainerInterface: CommandFactory = (ctx, goCtx) => {
143+
return () => {
144+
if (!goCtx.languageServerIsRunning) {
145+
vscode.window.showErrorMessage(
146+
'"Go: Start language server\'s maintainer interface" command is available only when the language server is running'
147+
);
148+
return;
149+
}
150+
vscode.commands.executeCommand('gopls.start_debugging', {}).then(undefined, (reason) => {
151+
vscode.window.showErrorMessage(
152+
`"Go: Start language server's maintainer interface" command failed: ${reason}`
153+
);
154+
});
155+
};
156+
};

src/goDeveloperSurvey.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ import { daysBetween, flushSurveyConfig, getStateConfig, minutesBetween, timeMin
1212
import { GoExtensionContext } from './context';
1313

1414
// Start and end dates of the survey.
15-
export const startDate = new Date('Jan 18 2023 00:00:00 GMT');
16-
export const endDate = new Date('Feb 8 2023 00:00:00 GMT');
15+
export const startDate = new Date('Jul 20 2023 00:00:00 GMT');
16+
export const endDate = new Date('Aug 10 2023 00:00:00 GMT');
1717

1818
// DeveloperSurveyConfig is the set of global properties used to determine if
1919
// we should prompt a user to take the gopls survey.
@@ -123,8 +123,8 @@ export function shouldPromptForSurvey(now: Date, cfg: DeveloperSurveyConfig): De
123123

124124
export async function promptForDeveloperSurvey(cfg: DeveloperSurveyConfig, now: Date): Promise<DeveloperSurveyConfig> {
125125
const selected = await vscode.window.showInformationMessage(
126-
`Help shape Go’s future! Would you like to help ensure that Go is meeting your needs
127-
by participating in this 10-minute Go Developer Survey (2023 Winter) before ${endDate.toDateString()}?`,
126+
`"Help shape Go’s future! Would you like to help ensure that Go is meeting your needs
127+
by participating in this 10-minute Go Developer Survey (2023 H2) before ${endDate.toDateString()}?`,
128128
'Yes',
129129
'Remind me later',
130130
'Never'
@@ -139,7 +139,7 @@ by participating in this 10-minute Go Developer Survey (2023 Winter) before ${en
139139
{
140140
cfg.lastDateAccepted = now;
141141
cfg.prompt = true;
142-
const surveyURL = 'https://google.qualtrics.com/jfe/form/SV_bNnbAtFZ0vfRTH8?s=p';
142+
const surveyURL = 'https://google.qualtrics.com/jfe/form/SV_4Vi4bNaMQhQdqSi?s=p';
143143
await vscode.env.openExternal(vscode.Uri.parse(surveyURL));
144144
}
145145
break;

src/goMain.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<ExtensionA
103103

104104
const registerCommand = commands.createRegisterCommand(ctx, goCtx);
105105
registerCommand('go.languageserver.restart', commands.startLanguageServer);
106+
registerCommand('go.languageserver.maintain', commands.startGoplsMaintainerInterface);
106107

107108
await commands.startLanguageServer(ctx, goCtx)(RestartReason.ACTIVATION);
108109

0 commit comments

Comments
 (0)