-
Notifications
You must be signed in to change notification settings - Fork 124
RELATED: RAIL-5218 Optimize build speed #4466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
extended test - backstop |
Build failed (check-extended pipeline). |
Build failed (check pipeline). |
dff3af4
to
776c065
Compare
Build failed (check pipeline). |
776c065
to
c7e94d3
Compare
extended test - backstop |
Build failed (check-extended pipeline). |
Build failed (check pipeline). |
c7e94d3
to
fc82011
Compare
extended test - backstop |
Build succeeded (check pipeline). |
Build failed (check-extended pipeline). |
extended test - tiger-cypress - isolated |
Build succeeded (check-extended pipeline). |
else | ||
build | ||
fi | ||
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new line
libs/sdk-ui-filters/scripts/build.sh
Outdated
else | ||
build | ||
fi | ||
build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add new line
extended test - cypress - isolated |
Build succeeded (check-extended pipeline). |
extended test - backstop |
Build failed (check-extended pipeline). |
import { storiesOf } from "../../../_infra/storyRepository.js"; | ||
import { UiKit } from "../../../_infra/storyGroups.js"; | ||
import { Button, Overlay, FullScreenOverlay } from "@gooddata/sdk-ui-kit"; | ||
|
||
import "../styles/goodstrap.scss"; | ||
|
||
const MediaQuery = DefaultMediaQuery as unknown as React.ComponentType<MediaQueryProps>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this will work in runtime. We had with this library problems. And solved via default-import
import DefaultMediaQuery from "react-responsive";
import { defaultImport } from "default-import";
// There are known compatibility issues between CommonJS (CJS) and ECMAScript modules (ESM).
// In ESM, default exports of CJS modules are wrapped in default properties instead of being exposed directly.
// microsoft/TypeScript#49189 (comment)
const MediaQuery = defaultImport(DefaultMediaQuery);
Build succeeded (check pipeline). |
extended test - tiger-cypress - isolated |
Build succeeded (check pipeline). |
Build failed (check-extended pipeline). |
extended test - backstop |
Build succeeded (check pipeline). |
Build failed (check-extended pipeline). |
extended test - tiger-cypress - isolated |
Build succeeded (check pipeline). |
Build succeeded (check-extended pipeline). |
extended test - cypress - isolated |
Build succeeded (check-extended pipeline). |
extended test - backstop |
Build failed (check pipeline). |
Build failed (check-extended pipeline). |
- Introduce rush caching. - Introduce incremental typescript builds. - Cleanup TS config files. - Replace babel-loader in favor of esbuild-loader where possible. - Migrate internal tooling from cjs to esm. JIRA: RAIL-5218
extended test - backstop |
Build succeeded (check pipeline). |
Build succeeded (check-extended pipeline). |
Sonar scan resultMore detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4466 To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'. |
Build succeeded (gate pipeline).
|
JIRA: RAIL-5218
Supported PR commands:
ok to test
extended check sonar
extended test - backstop
extended test - tiger-cypress - isolated <testName>
extended test - tiger-cypress - record <testName>
extended test - tiger-cypress - integrated <testName>
extended test - cypress - isolated <testName>
extended test - cypress - record <testName>
extended test - cypress - integrated <testName>
extended test - matrix-test <AIO_version>
<testName>
in cypress commands is used to filter specfiles. Example, to run record with BEAR backenddashboard.spec.ts
anddrilling.spec.ts
, execute commandextended test - cypress - record dashboard,drilling
extended test - cypress - record
orextended test - cypress - record *
<AIO_version>
in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins buildmaster
andstable
, execute commandextended test - matrix-test master,stable
orextended test - matrix-test latest
2.3.0
and2.3.1
, execute commandextended test - matrix-test 2.3.0,2.3.1
<AIO_version>
is empty, read versions from filecompTigerVersions.txt
of this repoPR Checklist
check
passesextended test - backstop
passesextended test - tiger-cypress - record
to record new mapping files (Tiger BE)extended test - cypress - record
to record new mapping files (Bear BE)extended test - tiger-cypress - isolated
passesextended test - cypress - isolated
passesextended test - tiger-cypress - integrated
passesrush change
was run if applicable