Skip to content

RELATED: RAIL-5218 Optimize build speed #4466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1 commit merged into from
Jan 4, 2024
Merged

Conversation

kandl
Copy link
Contributor

@kandl kandl commented Dec 20, 2023

  • Introduce rush caching.
  • Introduce incremental typescript builds.
  • Cleanup TS config files.
  • Replace babel-loader in favor of esbuild-loader where possible.
  • Migrate internal tooling from cjs to esm.

JIRA: RAIL-5218


Supported PR commands:

Command Description
ok to test Re-run standard checks
extended check sonar SonarQube tests
extended test - backstop BackstopJS tests
E2E Cypress tests commands - TIGER
extended test - tiger-cypress - isolated <testName> Run isolated tests running against recorded Tiger backend.
extended test - tiger-cypress - record <testName> Create a new recording for isolated Tiger tests.
extended test - tiger-cypress - integrated <testName> Run integrated tests against live backend
E2E Cypress tests commands - BEAR
extended test - cypress - isolated <testName> Run isolated tests running against recorded Bear backend.
extended test - cypress - record <testName> Create a new recording for isolated Bear tests.
extended test - cypress - integrated <testName> Run integrated tests against live backend
Compatibility matrix test commands - TIGER Backend
extended test - matrix-test <AIO_version> Run integrated tests against AIO versions.

<testName> in cypress commands is used to filter specfiles. Example, to run record with BEAR backend

  • Against dashboard.spec.ts and drilling.spec.ts, execute command extended test - cypress - record dashboard,drilling
  • Against all specfiles, execute command extended test - cypress - record or extended test - cypress - record *

<AIO_version> in commands is used to start test with multiple AIO instances - each instance in triggered by one jenkins build

  • To run with master and stable, execute command extended test - matrix-test master,stable or extended test - matrix-test latest
  • To run with specific version,ex: 2.3.0 and 2.3.1, execute command extended test - matrix-test 2.3.0,2.3.1
  • In case <AIO_version> is empty, read versions from file compTigerVersions.txt of this repo

PR Checklist

  • commit messages adhere to the commit message guidelines
  • review was done by a Code owner if necessary (if you think it is not necessary, explain the reasoning in the description or in a comment)
  • check passes
  • extended test - backstop passes
  • extended test - tiger-cypress - record to record new mapping files (Tiger BE)
  • extended test - cypress - record to record new mapping files (Bear BE)
  • extended test - tiger-cypress - isolated passes
  • extended test - cypress - isolated passes
  • extended test - tiger-cypress - integrated passes
  • rush change was run if applicable

@kandl kandl added the do not merge Do not merge this yet label Dec 20, 2023
@kandl
Copy link
Contributor Author

kandl commented Dec 20, 2023

extended test - backstop

@ghost
Copy link

ghost commented Dec 20, 2023

@ghost
Copy link

ghost commented Dec 20, 2023

@ghost
Copy link

ghost commented Dec 21, 2023

@kandl
Copy link
Contributor Author

kandl commented Dec 21, 2023

extended test - backstop

@ghost
Copy link

ghost commented Dec 21, 2023

@ghost
Copy link

ghost commented Dec 21, 2023

@kandl
Copy link
Contributor Author

kandl commented Dec 21, 2023

extended test - backstop

@ghost
Copy link

ghost commented Dec 21, 2023

@ghost
Copy link

ghost commented Dec 21, 2023

@kandl
Copy link
Contributor Author

kandl commented Dec 21, 2023

extended test - tiger-cypress - isolated

@ghost
Copy link

ghost commented Dec 21, 2023

else
build
fi
build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line

else
build
fi
build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add new line

@kandl
Copy link
Contributor Author

kandl commented Dec 21, 2023

extended test - cypress - isolated

@ghost
Copy link

ghost commented Dec 21, 2023

@kandl
Copy link
Contributor Author

kandl commented Dec 21, 2023

extended test - backstop

@ghost
Copy link

ghost commented Dec 21, 2023

import { storiesOf } from "../../../_infra/storyRepository.js";
import { UiKit } from "../../../_infra/storyGroups.js";
import { Button, Overlay, FullScreenOverlay } from "@gooddata/sdk-ui-kit";

import "../styles/goodstrap.scss";

const MediaQuery = DefaultMediaQuery as unknown as React.ComponentType<MediaQueryProps>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this will work in runtime. We had with this library problems. And solved via default-import

import DefaultMediaQuery from "react-responsive";
import { defaultImport } from "default-import";

// There are known compatibility issues between CommonJS (CJS) and ECMAScript modules (ESM).
// In ESM, default exports of CJS modules are wrapped in default properties instead of being exposed directly.
// microsoft/TypeScript#49189 (comment)
const MediaQuery = defaultImport(DefaultMediaQuery);

@ghost
Copy link

ghost commented Jan 3, 2024

@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - tiger-cypress - isolated

@ghost
Copy link

ghost commented Jan 3, 2024

@ghost
Copy link

ghost commented Jan 3, 2024

@kandl kandl added ready to review PR is ready to final code review and removed do not merge Do not merge this yet labels Jan 3, 2024
@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - backstop

@ghost
Copy link

ghost commented Jan 3, 2024

@ghost
Copy link

ghost commented Jan 3, 2024

@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - tiger-cypress - isolated

@ghost
Copy link

ghost commented Jan 3, 2024

@ghost
Copy link

ghost commented Jan 3, 2024

@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - cypress - isolated

@ghost
Copy link

ghost commented Jan 3, 2024

@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - backstop

@ghost
Copy link

ghost commented Jan 3, 2024

@ghost
Copy link

ghost commented Jan 3, 2024

- Introduce rush caching.
- Introduce incremental typescript builds.
- Cleanup TS config files.
- Replace babel-loader in favor of esbuild-loader where possible.
- Migrate internal tooling from cjs to esm.

JIRA: RAIL-5218
@kandl
Copy link
Contributor Author

kandl commented Jan 3, 2024

extended test - backstop

@ghost
Copy link

ghost commented Jan 3, 2024

@ghost
Copy link

ghost commented Jan 3, 2024

@ivanmjartan ivanmjartan added merge and removed ready to review PR is ready to final code review labels Jan 4, 2024
@yenkins
Copy link

yenkins commented Jan 4, 2024

Sonar scan result

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-ui-sdk-gate-PR4466

To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

@ghost ghost removed the merge label Jan 4, 2024
@ghost ghost merged commit f78f85c into gooddata:master Jan 4, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants