Skip to content

Refactor image processing functions for clarity and efficiency #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vruddhi18
Copy link
Contributor

Changes Made:

  • Removed superfluous comments that offered no value.
  • Simplified imports by removing unused ones.
  • Used asarray only once in normalize_images to avoid redundant conversions.
  • Refactored load_image_files for better readability and error handling.

@Vruddhi18
Copy link
Contributor Author

I would like to request the merging of the pull request I submitted. All checks have been successfully validated, and there are no errors present. The changes have been reviewed and approved.

Thank you for your attention to this matter.

@Conchylicultor
Copy link
Collaborator

Thank you for your contribution.

However in this case, I believe it's best to keep the docstrings and comments, as it gives more context to the user.

The unused imports are often due to some additional internal code in our codebase that is not released on GitHub, sometimes we forget to hide the associated import and they end up on GitHub

@Vruddhi18
Copy link
Contributor Author

Understood—I’ll retain the docstrings and comments and keep the unused imports as they are. Would you like me to update the code with the other improvements and then open a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants