Skip to content

runtimevar/filevar: TestReturnsUpdatedSnapshotConcurrently is flaky #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
zombiezen opened this issue May 31, 2018 · 3 comments · Fixed by #179
Closed

runtimevar/filevar: TestReturnsUpdatedSnapshotConcurrently is flaky #58

zombiezen opened this issue May 31, 2018 · 3 comments · Fixed by #179
Assignees
@zombiezen
Labels
code health Code health task, either refactoring or testing
Milestone
Sprint 19

Comments

@zombiezen
Copy link
Contributor

Example failure (source):

--- FAIL: TestReturnsUpdatedSnapshotConcurrently (0.10s)
	filevar_test.go:205: Snapshot.Value: {string}:
			-: ""
			+: `{"hello": "cloud"}`
FAIL
FAIL	github.com/google/go-cloud/runtimevar/filevar	10.241s
@zombiezen zombiezen added the code health Code health task, either refactoring or testing label May 31, 2018
@zombiezen zombiezen added this to the Sprint 14 milestone Jun 13, 2018
@cflewis cflewis mentioned this issue Jun 14, 2018
Merged
@cflewis
Copy link
Contributor

cflewis commented Jun 26, 2018

Propose we close this. I haven't seen it for a while.

@zombiezen
Copy link
Contributor Author

Sure.

@zombiezen zombiezen removed this from the Sprint 14 milestone Jun 26, 2018
@zombiezen
Copy link
Contributor Author

Fresh repro: https://travis-ci.com/google/go-cloud/jobs/133247297

@zombiezen zombiezen reopened this Jul 6, 2018
@zombiezen zombiezen self-assigned this Jul 6, 2018
@zombiezen zombiezen added the in progress This is being actively worked on label Jul 6, 2018
@zombiezen zombiezen mentioned this issue Jul 6, 2018
Merged
zombiezen added a commit that referenced this issue Jul 6, 2018
@zombiezen
runtimevar/filevar: synchronize concurrent tests (#179)
2e25497 
These tests were not properly handling partial reads and were
using sleeps. This should make the tests faster and more robust.
Since the flake happens so infrequently, it's hard for me to claim
that I've definitively fixed it, but I'm unable to induce a
failure locally after this change.

Fixes #58
@zombiezen zombiezen removed the in progress This is being actively worked on label Jul 19, 2018
@vangent vangent added this to the Sprint 19 milestone Nov 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombiezen zombiezen

Labels
code health Code health task, either refactoring or testing
Projects
None yet
Milestone
Sprint 19
Development

Successfully merging a pull request may close this issue.

runtimevar/filevar: synchronize concurrent tests
3 participants
@cflewis @zombiezen @vangent