Ensure that tag name is not empty if name contains colon #2094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
approved these changes
Jun 10, 2025
auto-merge was automatically disabled
June 10, 2025 15:56
Head branch was pushed to by a user without write access
SaschaSchwarze0
force-pushed
the
sascha-disallow-trailing-colon
branch
from
d85bed5 to
19bdf03
Compare
imjasonh
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following fails as I expected:
$ docker pull "library/ubuntu:" invalid reference formatBut gcr
name.ParseReference("library/ubuntu:")succeeds. It returns a tag and uses latest.This PR fixes the logic when parsing a tag that in case there is a colon, when it takes the last part as tag that this one is not an empty string.