Introduce a stub bazel wrapper for Windows #1201
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yukawa
force-pushed
the
bazel_tool
branch
4 times, most recently
from
f2c9ea1 to
be3600b
Compare
yukawa
changed the title
bazel_wrapper/bazel.bat
yukawa
force-pushed
the
bazel_tool
branch
3 times, most recently
from
f79d96f to
6392f84
Compare
|
Rebased to address merge conflict. |
This is a preparation before starting using 'clang-cl' to build Mozc for for Windows with Bazel (google#1179). In order to make the build process reliable and reproducible, we would like to download a specific version of LLVM with 'update_deps.py' then deploy it under 'third_party/llvm/' and let 'rules_cc' use it by specifying 'BAZEL_LLVM' environment variable [1]. To automate this process, one idea is to use 'tools/bazel' wrapper script [2]. Luckily the wrapper script directory is also customizable since bazelisk v1.21.0 [3]. With above this commit introduces a stub 'bazel.bat' so that we can use it to set various environment variables for Windows bazel build in subsequent commits. At this moment there must be no difference in the final artifacts. There should be no impact on non-Windows bazel build as 'bazel.bat' is searched only on Windows. [1]: https://bazel.build/configure/windows#clang [2]: https://github.com/bazelbuild/bazelisk/blob/master/README.md#toolsbazel [3]: bazelbuild/bazelisk#567
|
We have merged your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a preparation before starting using
clang-clto build Mozc for for Windows with Bazel (#1179).In order to make the build process reliable and reproducible, we would like to download a specific version of LLVM with
update_deps.pythen deploy it underthird_party/llvm/and letrules_ccuse it by specifyingBAZEL_LLVMenvironment variable.To automate this process, one idea is to use
tools/bazelwrapper script.Luckily the wrapper script directory is also customizable since bazelisk v1.21.0.
With above this commit introduces a stub
bazel.batso that we can use it to set various environment variables for Windows bazel build in subsequent commits. At this moment there must be no difference in the final artifacts. There should be no impact on non-Windows bazel build asbazel.batis searched only on Windows.Issue IDs
clang-clto build Mozc for Windows with Bazel #1179Steps to test new behaviors (if any)
bazelisk --bazelrc=windows.bazelrc build package --config oss_windows --config release_build