@AkshataABhat: Dockerfile enhancement: multistage build #995
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue aims to refactor the current Dockerfile to use a multistage build approach. The motivation for this change is to: 1. Reduce final image size by excluding unnecessary build-time dependencies (e.g., gcc, libpython3-dev, etc.) 2. Enhance maintainability by clearly separating build and runtime concerns ``` Size of the current docker image: 3.82GB Size of the docker image after multi-stage build: 1.06GB ``` Closes #990
|
/gcbrun exp -n ab -ag |
|
@AkshataABhat, unfortunately the experiment failed: |
|
@DonggeLiu I think I've figured out the issue. The python binary doesn't seem to exist in the second stage. I will correct this. |
DavidKorczynski
requested changes
Apr 16, 2025
|
At the moment, there's no significant improvement except a decrease in image size, but this can help isolate build dependencies from the runtime environment in the future, when support for fine-tuned or custom models is added. |
I agree to for the complexity point |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributed by @AkshataABhat via #991.