Skip to content

Enable fuzz testing of Rust code for project Oak #5719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2021

Conversation

rbehjati
Copy link
Contributor

@rbehjati rbehjati commented May 6, 2021

@asraa
Copy link
Contributor

asraa commented May 6, 2021

I'll re-run when the oak PR is merged!

@rbehjati
Copy link
Contributor Author

rbehjati commented May 7, 2021

@asraa Thanks for the review. The Oak PR is merged now. Could you please rerun the CI checks?

@rbehjati rbehjati force-pushed the enable-oak branch 2 times, most recently from a1f04b2 to d0bfb80 Compare May 10, 2021 12:05
@asraa
Copy link
Contributor

asraa commented May 10, 2021

Hmmm I think coverage might be hitting an llvm issue?

I think some other Rust projects were hitting this #4697 (comment)
rust-fuzz/cargo-fuzz#255

@catenacyber do you think so?

@catenacyber
Copy link
Contributor

Looks like a rust wrapper named rustc.py is missing here

@rbehjati
Copy link
Contributor Author

Thanks for the pointers. I am still looking into this. Locally, the error message I get is related to compiling tokio_util which seems to be different from the coverage errors on GitHub builds (before my most recent change).

@catenacyber
Copy link
Contributor

If the build error is related to one of the dependencies/crates, you can either :

  • use a rust wrapper to disable coverage for this specific crate
  • try to solve the problem for this specific crate...

@rbehjati rbehjati force-pushed the enable-oak branch 3 times, most recently from e67d175 to 327a84f Compare May 10, 2021 15:40
@rbehjati
Copy link
Contributor Author

If the build error is related to one of the dependencies/crates, you can either :

  • use a rust wrapper to disable coverage for this specific crate
  • try to solve the problem for this specific crate...

Thanks. That helped.

@asraa asraa merged commit a83b7c9 into google:master May 10, 2021
@rbehjati
Copy link
Contributor Author

We have received a failure report for a fuzz target that no longer exists: https://oss-fuzz.com/testcase?key=5379770520043520
Looks like oss-fuzz is running the old script. Could you please check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants