-
Notifications
You must be signed in to change notification settings - Fork 416
SBOM parsing improvements. #339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Be more relaxed about filename matching the spec when the SBOM is explicitly passed via --sbom since we've seen multiple complaints from different users about this. 2. Surface all parse errors when SBOM parsing fails (and we're explicitly scanning via --sbom). This will look something like: ``` Failed to parse SBOM using all supported formats: failed to parse SPDX: failed trying json: failed to parse Supplier 'Google LLC' failed trying rdf: found extra chars before tag start failed trying tv: no colon found in '{' failed to parse CycloneDX: failed trying json: invalid BOMFormat failed trying xml: XML syntax error on line 74: expected attribute name in element No package sources found, --help for usage information. exit status 128 ```
This reverts commit 06da59e.
michaelkedar
approved these changes
Apr 12, 2023
@another-rex does this look reasonable to you? |
another-rex
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just FYI the SPDX 0.5.0 has also been recently released which changes the interface up again, so this might need further tweaking when we upgrade that dependency.
yep, will address that separately later! |
This was referenced Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #335
This will look something like: