Skip to content

SBOM parsing improvements. #339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 13, 2023
Merged

SBOM parsing improvements. #339

merged 8 commits into from
Apr 13, 2023

Conversation

oliverchang
Copy link
Collaborator

Addresses part of #335

  1. Be more relaxed about filename matching the spec when the SBOM is explicitly passed via --sbom since we've seen multiple complaints from different users about this.
  2. Surface all parse errors when SBOM parsing fails (and we're explicitly scanning via --sbom).

This will look something like:

Failed to parse SBOM using all supported formats:
failed to parse SPDX:
        failed trying json: failed to parse Supplier 'Google LLC'
        failed trying rdf: found extra chars before tag start
        failed trying tv: no colon found in '{'
failed to parse CycloneDX:
        failed trying json: invalid BOMFormat
        failed trying xml: XML syntax error on line 74: expected attribute name in element
No package sources found, --help for usage information.
exit status 128

1. Be more relaxed about filename matching the spec when the SBOM is
   explicitly passed via --sbom since we've seen multiple complaints from
   different users about this.
2. Surface all parse errors when SBOM parsing fails (and we're
   explicitly scanning via --sbom).

This will look something like:

```
Failed to parse SBOM using all supported formats:
failed to parse SPDX:
        failed trying json: failed to parse Supplier 'Google LLC'
        failed trying rdf: found extra chars before tag start
        failed trying tv: no colon found in '{'
failed to parse CycloneDX:
        failed trying json: invalid BOMFormat
        failed trying xml: XML syntax error on line 74: expected attribute name in element
No package sources found, --help for usage information.
exit status 128
```
This reverts commit 06da59e.
@oliverchang
Copy link
Collaborator Author

oliverchang commented Apr 13, 2023

@another-rex does this look reasonable to you?

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just FYI the SPDX 0.5.0 has also been recently released which changes the interface up again, so this might need further tweaking when we upgrade that dependency.

@oliverchang
Copy link
Collaborator Author

yep, will address that separately later!

@oliverchang oliverchang enabled auto-merge (squash) April 13, 2023 22:30
@oliverchang oliverchang merged commit dd3f7a5 into main Apr 13, 2023
@oliverchang oliverchang deleted the spdx-improvements branch April 13, 2023 22:31
@oliverchang oliverchang mentioned this pull request Apr 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants