update govulncheck integration #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
another-rex
reviewed
Jul 3, 2023
internal/sourceanalysis/go.go
Outdated
| if !ok { // If vulnerability not found, check if it contain any source information | ||
| fillNotImportedAnalysisInfo(vulnsByID, vulnID, pv, analysis) | ||
| continue | ||
| } | ||
| // Module list is unlikely to be very big, linear search is fine | ||
| containsModule := slices.ContainsFunc(gvcVuln.Modules, func(module *govulncheck.Module) bool { | ||
| return module.Path == pv.Package.Name | ||
| var modulePaths []string |
There was a problem hiding this comment.
This part can be replaced a direct map key check, something like:
called, hasModule := moduleToCalled[pv.Package.Name];
(*analysis)[vulnID] = models.AnalysisInfo{
Called: hasModule && called,
}
There was a problem hiding this comment.
Nice catch! I left out the hasModule bit, since we want to set Called to false regardless of if pv.Package.Name is not in the map, or is present but has a value of false
Added |
another-rex
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.