Fix PURLToPackage function and move it #439
Merged
+162
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
suggested changes
Jul 11, 2023
oliverchang
approved these changes
Jul 11, 2023
oliverchang
reviewed
Jul 11, 2023
| // Debian and Alpine repeats their namespace in PURL, so don't add it to the name | ||
| name = parsedPURL.Name | ||
| default: | ||
| name = parsedPURL.Namespace + "/" + parsedPURL.Name |
There was a problem hiding this comment.
Is this definitely the case in all other ecosystems?
There was a problem hiding this comment.
I'm pretty sure this is the case for all other ecosystems in osv right now, going by the package_to_purl function in python:
If we add more linux distros we'll also need to remove the namespace for them as well.
G-Rath
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out our
PURLToPackagefunction was returning incorrect results for ecosystems that contain a namespace like golang, the returned result was simply missing the full namespace (github.com/author/...). When adding the namespace, there's also some exceptions with some ecosystems (e.g. Maven uses:, debian and alpine repeats their name in their namespace, etc).This also moves the
PURLToPackageto themodelspackage instead ofosvscanner, deprecating the existing one inosvscannerbecause:model.Also added additional tests to clarify behavior and prevent regressions in the future.