Guided Remediation: Add computation for all relaxation patches #766
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #766 +/- ##
=======================================
Coverage 79.72% 79.72%
=======================================
Files 89 89
Lines 6145 6145
=======================================
Hits 4899 4899
Misses 1043 1043
Partials 203 203 ☔ View full report in Codecov by Sentry. |
oliverchang
reviewed
Jan 25, 2024
oliverchang
approved these changes
Jan 28, 2024
cuixq
approved these changes
Jan 28, 2024
another-rex
approved these changes
Jan 28, 2024
michaelkedar
added a commit
that referenced
this pull request
Jan 29, 2024
Implementing #766 (comment) - Created `VulnerabilityClient` interface for OSV queries & to store cache - Renamed `ResolutionClient` to `DependencyClient` - Made new `ResolutionClient` struct, that's just both `DependencyClient` and `VulnerabilityClient` together
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #765, adds
ComputeRelaxPatchesfor generating the possible remediation options after a relock.Also added a new(ish) cache for OSV API requests, which speeds up the above quite a bit.