Skip to content

FromZeroes is misspelt #431

Closed
Closed
@jswrenn

Description

@jswrenn

We need to rename FromZeroes to FromZeros. We attempted this in #430, by doing the rename, and providing an alias:

/// Deprecated: prefer [`FromZeros`] instead.
#[doc(hidden)]
pub use FromZeros as FromZeroes;

The intention here was that this would gently nudge users towards FromZeros, and then in 0.8, we would add a deprecated notice:

#[deprecated(since = "0.8.0", note = "FromZeroes has been renamed to FromZeros")]

However, we found from our UI tests that Rust recommends using "FromZeroes" in its suggestions — even when it's both doc(hidden) and deprecated. This would have the opposite of the intended effect.

We need to investigate whether this is a fixable Rust bug, and if there is any action we can take before 0.8.

Metadata

Metadata

Assignees

No one assigned

    Labels

    blocking-next-releaseThis issue should be resolved before we release on crates.io

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions