chore: update generation config #3749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: xl
product-auto-label
bot
added
size: s
product-auto-label
bot
added
size: xl
This reverts commit b2a194c.
…is/sdk-platform-java into generate-libraries-main
suztomo
reviewed
Apr 18, 2025
| --baseline-generation-config-path="${baseline_generation_config}" \ | ||
| --current-generation-config-path="${generation_config}") | ||
| --current-generation-config-path="${generation_config}" | tee > "${changed_libraries_file}" |
There was a problem hiding this comment.
The tee command doesn't need ">".
suztomo
reviewed
Apr 18, 2025
| --baseline-generation-config-path="${baseline_generation_config}" \ | ||
| --current-generation-config-path="${generation_config}") | ||
| --current-generation-config-path="${generation_config}" | tee > "${changed_libraries_file}" | ||
| changed_libraries=$(cat "${changed_libraries_file}") | ||
| echo "Changed libraries are: ${changed_libraries:-"No changed library"}." |
There was a problem hiding this comment.
I suspect this double quotations included in double quotations. Check this before submitting this.
There was a problem hiding this comment.
I surrounded the whole variable with double quotes now.
suztomo
approved these changes
Apr 18, 2025
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty commit messages, skip creating pull request description.Fixes #3745