This repository was archived by the owner on Sep 21, 2020. It is now read-only.
[GPII-4211]: Override NS records created by google_dns_managed_zone to set proper TTL #574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds record sets to override all NS records created by
google_dns_managed_zoneprimitives to set the proper TTL (3600) instead of default one (21600).It is impossible to set TTL for the records created by
google_dns_managed_zone:hashicorp/terraform-provider-google#5280
However, as it turns out, TF does not care about DNS records, created by
google_dns_managed_zone– as long as the zone entity is unchanged, other records can be modified without causing a conflict.I tested this running common part only for my project – deployment should be seamless.