Add quarkus-artifact.properties as an output of quarkus:build #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jprinet |
When running ITs for native, we need quarkus-artifact.properties to be around so it needs to be part of the cache. Also make it an input of Failsafe. This file contains a relative path to the binary to run and a few additional metadata such as the full GraalVM version. Whenever this version has changed, we need to run the tests again so it makes sense to make it an input. Note that we will need quarkusio/quarkus#41587 to be in so that quarkus-artifact.properties doesn't contain a timestamp. Signed-off-by: Guillaume Smet <[email protected]>
gsmet
force-pushed
the
quarkus-artifact.properties
branch
from
15fc24e to
fbac480
Compare
|
Note that we will need a release of the extension and an update in Quarkus once this is included as it's in the way of our CI. Thanks! |
Signed-off-by: Guillaume Smet <[email protected]>
gsmet
force-pushed
the
quarkus-artifact.properties
branch
from
279fc2a to
eb64a6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the cache for quarkus:build has been fixed in the Quarkus CI, we are starting to see failures because the
target/quarkus-artifact.propertiesis missing. This is because it's not part of the cache so whenever we have a cache hit, it's not restored.When running ITs for native, we need quarkus-artifact.properties to be around so it needs to be part of the cache.
Also make it an input of Failsafe.
This file contains a relative path to the binary to run and a few additional metadata such as the full GraalVM version. Whenever this version has changed, we need to run the tests again so it makes sense to make it an input.
Note that we will need quarkusio/quarkus#41587 to be in so that quarkus-artifact.properties doesn't contain a timestamp.