Bump Alertmanager version to include silence fixes #211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grobinson-grafana
force-pushed
the
grobinson/update-fork
branch
from
786d1a3 to
5320535
Compare
grobinson-grafana
changed the title
grobinson-grafana
force-pushed
the
grobinson/update-fork
branch
from
5320535 to
e33cec6
Compare
This commit updates Alertmanager to the include the fixes to silences in grafana/prometheus-alertmanager#88. Upsert no longer returns the id of the upserted silence as it is redundant. The id is stored in the silence and can be accessed via sil.Id. This brings the behaviour of Upsert inline with Set, which also removed the id from its return values.
grobinson-grafana
force-pushed
the
grobinson/update-fork
branch
from
e33cec6 to
6f37e05
Compare
grobinson-grafana
added a commit
that referenced
this pull request
Jun 26, 2024
Bump Alertmanager This commit updates Alertmanager to the include the fixes to silences in grafana/prometheus-alertmanager#88. Upsert no longer returns the id of the upserted silence as it is redundant. The id is stored in the silence and can be accessed via sil.Id. This brings the behaviour of Upsert inline with Set, which also removed the id from its return values.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates Alertmanager to the include the fixes to silences in grafana/prometheus-alertmanager#88.
Upsertno longer returns the id of the upserted silence as it is redundant. The id is stored in the silence and can be accessed via sil.Id. This brings the behaviour ofUpsertinline withSet, which also removed the id from its return values.