Allow the creation of silences with pre-set IDs #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we need to modify the fork, we have access to the underlying silences struct directly in https://github.com/grafana/alerting/blob/main/notify/silences.go |
|
@gotjosh we can add the ID to the silence struct before creating it, but if we try to create a silence with a predefined ID the Alertmanager will return |
santihernandezc
force-pushed
the
santihernandezc/add_upsert_silence_method
branch
from
4070531 to
e2f2ed9
Compare
santihernandezc
changed the title
santihernandezc
force-pushed
the
santihernandezc/add_upsert_silence_method
branch
from
c35d1f4 to
e2f2ed9
Compare
gotjosh
approved these changes
Mar 21, 2024
|
@gotjosh I checked and it has failed on the same step for the last few PRs, I'll submit an issue to fix it |
|
When cherry-picking this PR, please make sure to include the added test coverage here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an
Upsertoption toSilences.Set()to create new silences with pre-set IDs. Instead of returningErrNotFound, we create a silence using that ID. This is useful when replicating silences between the internal and remote Alertmanager (e.g. if we need to delete the same silence in both Alertmanagers).