Instrumentation support for dataloader #175
Open
+1,254
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edDataLoaderInstrumentation
…erInstrumentationContext
bbakerman
commented
Jan 22, 2025
| @@ -561,7 +561,7 @@ public Builder<K, V> options(DataLoaderOptions options) { | |||
| return this; | |||
| } | |||
|
|
|||
| DataLoader<K, V> build() { | |||
| public DataLoader<K, V> build() { | |||
|
Hey Brad, I have used this PR in my local setup to implement spring-projects/spring-graphql#1034 and it works really well. I can now instrument dataloader calls without conflating them with regular data fetcher calls:
So, all good from my perspective and ready to adopt this feature when it's out. |
…port # Conflicts: # src/main/java/org/dataloader/DataLoaderOptions.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is now complete and ready to be merged.
DataLoaderOptions is now immutable and hence some teaks t the original code had been done