Skip to content

GRA-1493: fixed hard coded dns key #2170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

GRA-1493: fixed hard coded dns key #2170

merged 1 commit into from
Apr 4, 2023

Conversation

0xdcarns
Copy link
Contributor

@0xdcarns 0xdcarns commented Apr 3, 2023

Describe your changes

Fixed security issue

Provide Issue ticket number if applicable/not in title

title.

Provide testing steps

  • don't set the DNS_KEY env and query a DNS GET request like curl localhost:8081/api/dns/adm/{network}/nodes
    • Ensure you get an unauthorized response
  • set the DNS_KEY env var and query the same one, with -H "Authorization:Bearer ", ensure you get a 500 (if no nodes) otherwise a good response

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netmaker is awesome.

Copy link
Contributor

@theguy951357 theguy951357 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr steps pass
critical list passes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants