Skip to content

Point to 2-0-stable branch #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Point to 2-0-stable branch #28

wants to merge 2 commits into from

Conversation

rterbush
Copy link
Contributor

I can resend this to point to 2-0-stable branch when/if you create it.

@greendog
Copy link
Owner

@rterbush i have conflicts for it commit

@rterbush
Copy link
Contributor Author

Entirely up to you if you want to create a 2-0-stable branch and freeze that development. Not sure it matters as I am not aware of anything in the extension that would be a problem going forward for newer Spree versions.

I've created a 2-0-stable on my fork so I have something to point to for future installs.

@keilmillerjr
Copy link

This gem is currently broken.

Master Branch : spree_contact_us.gemspec

  s.add_dependency 'spree_core', '~> 2.1.0.beta'

Error when running the bundle command

Bundler could not find compatible versions for gem "spree_core":
  In snapshot (Gemfile.lock):
    spree_core (2.0.3)

  In Gemfile:
    spree_contact_us (>= 0) ruby depends on
      spree_core (~> 2.1.0.beta) ruby

This is due to me using 2-0-stable release of spree and components by targeting a release specific branch. This gem should follow the same method to alleviate these incompatibilities.

@szechyjs
Copy link

szechyjs commented Nov 3, 2013

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants