Skip to content

build(mvnw): add Maven wrapper for build consistency #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Dec 15, 2017
Merged

build(mvnw): add Maven wrapper for build consistency #11

merged 19 commits into from
Dec 15, 2017

Conversation

gregswindle
Copy link
Owner

@gregswindle gregswindle commented Dec 15, 2017 •
edited
Loading

Description of change

Add a Maven wrapper for consistency with takari/maven-wrapper.

Associated issue(s)

Closes #10

PR check-list

✅ Please review and check the appropriate items.

1. Acceptance criteria

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

2. Test coverage Coverage Status

  • The source code is 100% covered with passing specs.

3. Code standards compliance

JavaScript Style Guide Google Checkstyle Docs

3.1. JavaScript

  • ESLint passes.

3.2. Java

  • Checkstyle passes
  • PMD passes
  • Findbugs passes

4. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

greenkeeper bot and others added 15 commits November 9, 2017 03:53
@greenkeeper
chore(package): update dependencies
a22b05e
@greenkeeper
docs(readme): add Greenkeeper badge
77ee83c
@gregswindle
Merge branch 'master' into greenkeeper/initial
259ea5d
@gregswindle
docs(readme): add greenkeeper badge
1d99ae1 
Closes #1
@gregswindle
docs(license): edit license badge's alt text
5b390c9 
Alt text is now "MIT License"

#1, #$
@gregswindle
Merge branch 'master' into greenkeeper/initial
552b79f
docs(readme): init greenkeeper
72e190c 
Clean up README, too.

#1,#5
@gregswindle
Merge branch 'master' into greenkeeper/initial
6fb1ff2
@gregswindle
Merge branch 'master' of https://github.com/gregswindle/maven-code-qu…
492a206 
…ality-pom into greenkeeper/initial
@gregswindle
Merge branch 'greenkeeper/initial' of https://github.com/gregswindle/…
9567f4e 
…maven-code-quality-pom into greenkeeper/initial
ci(blackduck-copilot): enable CoPilot SaaS
dd0038e
ci(dependency-ci): add config for removed libs
7dd7d35
fix(pom): Running "mvn site" results in error with message "Could not…
98c5d84 
… connect to Central search"

Applied the fix described here: jeremylong/DependencyCheck#978

#8
@gregswindle
Merge branch 'greenkeeper/initial' of https://github.com/gregswindle/…
827f92f 
…maven-code-quality-pom into greenkeeper/initial
@gregswindle
Merge branch 'fix/#8-maven-site-life-cycle-error' of https://github.c…
d1e6dbe 
…om/joquijada/maven-code-quality-pom into joquijada/fix/#8-maven-site-life-cycle-error
@gregswindle gregswindle self-assigned this Dec 15, 2017
@coveralls
Copy link

coveralls commented Dec 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 58360d9 on build/#10-maven-wrapper into b5c1b85 on master.

@coveralls
Copy link

coveralls commented Dec 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 58360d9 on build/#10-maven-wrapper into b5c1b85 on master.

@gregswindle gregswindle changed the title Build/#10 maven wrapper build(mvnw): add Maven wrapper for build consistency Dec 15, 2017
@coveralls
Copy link

coveralls commented Dec 15, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 03670de on build/#10-maven-wrapper into b5c1b85 on master.

@gregswindle gregswindle merged commit 2a96fcd into master Dec 15, 2017
@gregswindle gregswindle deleted the build/#10-maven-wrapper branch December 15, 2017 06:11
gregswindle added a commit that referenced this pull request Dec 17, 2017
@gregswindle
style(java): add source code formatter (#14)
db550ae 
* chore(license): might need to evaluate a LGLPL license.

* chore(package): update dependencies

* docs(readme): add Greenkeeper badge

* docs(readme): add greenkeeper badge

Closes #1

* docs(license): edit license badge's alt text


Alt text is now "MIT License"

#1, #$

* docs(readme): init greenkeeper

Clean up README, too.

#1,#5

* ci(blackduck-copilot): enable CoPilot SaaS

* ci(dependency-ci): add config for removed libs

* fix(pom): Running "mvn site" results in error with message "Could not connect to Central search"

Applied the fix described here: jeremylong/DependencyCheck#978

#8

* build(mvnw): add /.mvn/ directory

#10

* docs(styleguide): add markdown styleguide

Format all Java source

#10,#11

* docs(mvn-site): update with latest info

* ci(quality): add tooling

1. google-java-format: format all source code
2. javac-with-errorprone: static code analyzer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gregswindle gregswindle

Labels
Priority: Medium Type: Build Type: CI
Projects
None yet
Milestone
Create qa-gateway test artifacts
Development

Successfully merging this pull request may close these issues.
2 participants
@gregswindle @coveralls