Skip to content

docs(reports): publish maven site to GitHub Pages #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 10, 2017
Merged

docs(reports): publish maven site to GitHub Pages #6

merged 1 commit into from
Nov 10, 2017

Conversation

gregswindle
Copy link
Owner

@gregswindle gregswindle commented Nov 10, 2017 •
edited
Loading

Description of change

Publish HTML docs to GitHub pages.

Associated issue(s)

Closes #4

PR check-list

✅ Please review and check the appropriate items.

1. Acceptance criteria

  • The acceptance criteria for all associated issues have been completed, tested, and validated.

2. Test coverage Coverage Status

  • N/A The source code is 100% covered with passing specs.

3. Code standards compliance

JavaScript Style Guide Google Checkstyle Docs

3.1. JavaScript

  • N/A ESLint passes.

3.2. Java

  • N/A Checkstyle passes
  • N/A PMD passes
  • N/A Findbugs passes

4. Code quality Quality Gate

  • The quality gateways pass with an "A" grade.
Measure Scores
Complexity Complexity
Cognitive complexity
Complexity per Class
Complexity per file
Complexity per Function
Duplications Duplications
Issues Issues
Maintainability Code smells
Maintainability
Technical debt
Reliability Reliability
Security Security

ℹ️ These tasks are not required to open a PR, and may be addresses while the PR is open.

@gregswindle gregswindle self-assigned this Nov 10, 2017
accesslint[bot]
accesslint bot suggested changes Nov 10, 2017
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

docs/index.html
</ul>
<form id="search-form" action="https://www.google.com/search" method="get" >
<input value="github.com/gregswindle/maven-code-quality-pom" name="sitesearch" type="hidden"/>
<input class="search-query" name="q" id="query" type="text" />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a label missing for this input. That makes it hard for people using screen readers or voice control to use the input. If you don't want a visual label, try an aria-label attribute.

@coveralls
Copy link

coveralls commented Nov 10, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling a5e4a1d on docs/#4-reporting-sample into 029b8dc on master.

@gregswindle gregswindle merged commit eee3df0 into master Nov 10, 2017
@gregswindle gregswindle deleted the docs/#4-reporting-sample branch November 10, 2017 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@accesslint accesslint[bot] accesslint[bot] requested changes

Assignees

@gregswindle gregswindle

Labels
Priority: Low Status: Completed Type: Build Type: CI Type: Docs Type: Feature
Projects
None yet
Milestone
Create qa-gateway test artifacts
Development

Successfully merging this pull request may close these issues.
2 participants
@gregswindle @coveralls