Change dumpwallet to use appropriate data directory

[jamescowens]

by default, with the ability to provide an override to
that in the filespec.

This should also fix the functionality in the debug console.

I have tested in the debug console of both Linux and Windows with just

dumpwallet filename and it works - it appropriately put it in the testnet subdirectory under the data directory.

I tested Linux with dumpwallet /home/jco/walletkeys.dat on testnet and it put it in the specified pathspec.

I tested Windows with dumpwallet "C:\users\JCO\Documents\walletkeys.dat" and it put it in the correct directory. You need to use the quotes. Before the functionality was totally broken in the UI debug console on Windows.

[jamescowens]

Ah. @denravonska you should also merge this into staging. It will apply equally well there, and we may need it for beacon testing.

[jamescowens]

Note that Bitcoin's version of this in 0.17 has the following help...

RPCHelpMan{"dumpwallet",
"\nDumps all wallet keys in a human-readable format to a server-side file. This does not allow overwriting existing files.\n"
"Imported scripts are included in the dumpfile, but corresponding BIP173 addresses, etc. may not be added automatically by importwallet.\n"
"Note that if your wallet contains keys which are not derived from your HD seed (e.g. imported keys), these are not covered by\n"
"only backing up the seed itself, and must be backed up too (e.g. ensure you back up the whole dumpfile).\n",
{
{"filename", RPCArg::Type::STR, RPCArg::Optional::NO, "The filename with path (either absolute or relative to bitcoind)"},
},
RPCResult{
"{ (json object)\n"
" "filename" : { (string) The filename with full absolute path\n"
"}\n"
},
RPCExamples{
HelpExampleCli("dumpwallet", ""test"")
+ HelpExampleRpc("dumpwallet", ""test"")
},
}.ToString());

Here is a test from the command line for jco@jco-linux just specifiying a filename without a path. Notice that I changed to the home directory to see where it would put the file. (Would it put the file where I called the daemon from (CWD) or the data directory:

/.bitcoin> cd ~
jco@jco-linux:> ./.bitcoin/bitcoin-cli.sh dumpwallet walletkeys_bitcoin.dat
{
"filename": "/data2/home/jco/.bitcoin/walletkeys_bitcoin.dat"
}

/data2/home/jco/.bitcoin/walletkeys_bitcoin.dat is not where bitcoind is. This is the data directory. bitcoind is actually in the bin subdirectory underneath that. So bitcoin is really defaulting to the data directory. Their documentation is misleading.

[denravonska]

Me and @jamescowens had a chat about this on Slack after I wanted us to follow the Bitcoin implementation. However, it's not clear what its implementation is relative to. It says bitcoind but it seems to vary across platforms.

utACK on this as it is very likely it will change in Bitcoin before we rebase.

[jamescowens]

Merging this now. The behavior is consistent with what bitcoin-cli is doing on Linux, although other platforms may be different.

In our implementation here, the path if specified can be either absolute or relative to the data directory. It defaults to the data directory (i.e. equivalent to ./filename).

This is good enough until Bitcoin sorts theirs out.